Cancel unsafe queries

2 posts
[expired user #9382]'s profile image [expired user #9382] posted 9 years ago in Feature discussion Permalink
Hey all,

I ran into a usability issue with HeidiSQL and wasn't sure where else to put this, so here it is.

Whenever I run a query like
"UPDATE table SET column = 1"

I get a notification with the following popup:
"Unsafe queries found. Your query contains UPDATEs and/or DELETEs without a WHERE clause. Please confirm that you know what you're doing."

In a case like this, my reaction is to cancel the operation, recheck everything and then fire the query again. Typos happen after all.
Because the confirm and cancel button are not always in the same location for different application, my default choice is to close the modal, expecting that nothing will happen (after all, I did not "confirm that I knew what I was doing").
To my great surprise, this lead to the queries being executed, and some time ago, caused all our 1.6 million orders to be moved to the "Ready for production" status.

Can this be changed?

Thanks in advance

Lex
10378 posts
ansgar's profile image ansgar posted 9 years ago Permalink
Yes, of course. Should be "no" when the "X" button is clicked.
Code modification/commit c259410 from ansgarbecker, 9 years ago, revision 9.3.0.5000
A yes/no message dialog may also return mrCancel, when the user clicks the X button to close it. Handle this case as if the user clicked "no", when HeidiSQL detects an unsafe query. See http://www.heidisql.com/forum.php?t=19697
10378 posts
ansgar's profile image ansgar posted 9 years ago Permalink
r5000 handles the "X" button as if the user clicked "no".
2 posts
[expired user #9382]'s profile image [expired user #9382] posted 9 years ago Permalink
That's quick! Thanks!

Please login to leave a reply, or register at first.